diff options
| author |  Michael Smith <mikesmiffy128@gmail.com>
| 2025-03-10 02:37:19 +0000 |
|---|---|---|
| committer | Michael Smith <mikesmiffy128@gmail.com>
| 2025-04-06 16:41:13 +0100 |
| commit | 244fea664121acf12871ab5858a5fe95a2606b52 (patch) | |
| tree | e42b1990ef97adc0f0ab48b9be7e11de7fee0558 /src/demorec.c | |
| parent | d86b7b41453c69b3854baa7cdc05a79a3cdfe092 (diff) | |
| download | sst-244fea664121acf12871ab5858a5fe95a2606b52.tar.gz sst-244fea664121acf12871ab5858a5fe95a2606b52.zip | |
Rewrite and redesign codegen and feature system
Also switch to somewhat proper C23 flags while we're at it.
This is a huge change. It took me forever, in between being really busy.
Sorry about that. But the good news is I'm now free to start integrating
the various patches that have accumulated since last release. Well, at
least in between still being really busy. Gotta manage expectations.
The main benefit of introducing GAMESPECIFIC() is that features
that don't apply to a particular game no longer show up *at all*, and
less time is wasted on init. It also enables a cool optimisation wherein
unnecessary REQUIRE_GAMEDATA() checks can elided at compile time
whenever the gamedata is known up-front to always exist in supported
games.
The DEF_FEAT_CVAR macro family meanwhile makes it easier to manage the
lifecycle of cvars/ccmds, with less manual registering, unhiding and
such.
Originally I was going to try and just hack these features into the
existing codegen abomination, but it just got too terrible. This rewrite
should make it easier to continue tweaking codegen behaviour in future.
It also has slightly better error messages.
Diffstat (limited to 'src/demorec.c')
| -rw-r--r-- | src/demorec.c | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/src/demorec.c b/src/demorec.c index 4a8efb5..66ffa1d 100644 --- a/src/demorec.c +++ b/src/demorec.c @@ -1,6 +1,6 @@ /* * Copyright © 2021 Willian Henrique <wsimanbrazil@yahoo.com.br> - * Copyright © 2024 Michael Smith <mikesmiffy128@gmail.com> + * Copyright © 2025 Michael Smith <mikesmiffy128@gmail.com> * * Permission to use, copy, modify, and/or distribute this software for any * purpose with or without fee is hereby granted, provided that the above @@ -38,8 +38,8 @@ FEATURE("improved demo recording") REQUIRE_GAMEDATA(vtidx_StopRecording) -DEF_CVAR(sst_autorecord, "Continuously record demos even after reconnecting", 1, - CON_ARCHIVE | CON_HIDDEN) +DEF_FEAT_CVAR(sst_autorecord, + "Continuously record demos even after reconnecting", 1, CON_ARCHIVE) void *demorecorder; static int *demonum; @@ -261,21 +261,21 @@ INIT { orig_stop_cb = con_getcmdcb(cmd_stop); if_cold (!find_demorecorder()) { errmsg_errorx("couldn't find demo recorder instance"); - return false; + return FEAT_INCOMPAT; } void **vtable = mem_loadptr(demorecorder); // XXX: 16 is totally arbitrary here! figure out proper bounds later if_cold (!os_mprot(vtable, 16 * sizeof(void *), PAGE_READWRITE)) { errmsg_errorsys("couldn't make virtual table writable"); - return false; + return FEAT_FAIL; } if_cold (!find_recmembers(vtable[vtidx_StopRecording])) { errmsg_errorx("couldn't find recording state variables"); - return false; + return FEAT_INCOMPAT; } if_cold (!find_demoname(vtable[vtidx_StartRecording])) { errmsg_errorx("couldn't find demo basename variable"); - return false; + return FEAT_INCOMPAT; } orig_SetSignonState = (SetSignonState_func)hook_vtable(vtable, @@ -286,8 +286,7 @@ INIT { cmd_record->cb = &hook_record_cb; cmd_stop->cb = &hook_stop_cb; - sst_autorecord->base.flags &= ~CON_HIDDEN; - return true; + return FEAT_OK; } END { |