diff options
| author |  Michael Smith <mikesmiffy128@gmail.com>
| 2025-04-17 01:39:10 +0100 |
|---|---|---|
| committer | Michael Smith <mikesmiffy128@gmail.com>
| 2025-04-17 20:02:18 +0100 |
| commit | 8a669bc96ffdb9d0f6f54e464da11e3375c80a55 (patch) | |
| tree | 569dac0cd082ad25e779a69f0bcceff5ca212bb1 /src/demorec.h | |
| parent | 0b40d4d9ea1cbfbb92795e0d6f26cf108f2dec5f (diff) | |
| download | sst-8a669bc96ffdb9d0f6f54e464da11e3375c80a55.tar.gz sst-8a669bc96ffdb9d0f6f54e464da11e3375c80a55.zip | |
Add type-safety to virtual calls and accessors
This probably should have been the design from the start.
It's still possible to use void pointers, and this is done in a couple
of places for simplicity, but wherever possible, we have actual structs
for things now.
Additionally, in places where vtables are fiddled with, e.g. vtable
hooks, we have actual struct definitions with vtable pointers so there's
need for pointer-casting horror.
Diffstat (limited to 'src/demorec.h')
| -rw-r--r-- | src/demorec.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/demorec.h b/src/demorec.h index 63009a0..4e33cc5 100644 --- a/src/demorec.h +++ b/src/demorec.h @@ -20,8 +20,9 @@ #include "event.h" -// For internal use by democustom -extern void *demorecorder; +// For internal use by democustom. Consider this opaque. +// XXX: should the struct be put in engineapi or something? +extern struct CDemoRecorder { void **vtable; } *demorecorder; /* * Whether to ignore the value of the sst_autorecord cvar and just keep |